Skip to main content

[Code refactoring] HttpClient status code

Last night I had some time to look over a project that is on CodePlex. There I found the following code:
using (var httpClient = new HttpClient())
{
  httpClient.BaseAddress = fooUrl;
  FooMessage message = new FooMessage()
  {
    ...
  }
  Task<HttpResponseMessage> response = httpClient.PostAsJsonAsync("api/foo", message);
  response.Wait();
    if (response.Result.StatusCode != HttpStatusCode.OK)
                {
                    throw new Exception("...");
                }
}
What do you see strange in this code?
Well, there is a check if the return code was 200 (OK) and if not, throw an exception.
This is not the wrong way to go, but you should know that HttpClient already contains a method that can check if the return code was 200 (OK). This method will throw an exception automatically if the return code is not the expected one.
The above code could be written in the following way:
using (var httpClient = new HttpClient())
{
  httpClient.BaseAddress = fooUrl;
  FooMessage message = new FooMessage()
  {
    ...
  }
  Task<HttpResponseMessage> response = httpClient.PostAsJsonAsync("api/foo", message);
  response.Wait();
  response.Result.EnsureSuccessStatusCode();
}
If you wouldn't want to throw an exception, only to check if the status code was okay you could also use the property IsSuccessStatusCode of the result.

The most important thing is to know the available API when you start to use different core features.

Comments

  1. The two codes are not equivalent, guess why? :)
    (depending on the problem, the first or the second one might be buggy, or none)

    ReplyDelete

Post a Comment

Popular posts from this blog

Windows Docker Containers can make WIN32 API calls, use COM and ASP.NET WebForms

After the last post , I received two interesting questions related to Docker and Windows. People were interested if we do Win32 API calls from a Docker container and if there is support for COM. WIN32 Support To test calls to WIN32 API, let’s try to populate SYSTEM_INFO class. [StructLayout(LayoutKind.Sequential)] public struct SYSTEM_INFO { public uint dwOemId; public uint dwPageSize; public uint lpMinimumApplicationAddress; public uint lpMaximumApplicationAddress; public uint dwActiveProcessorMask; public uint dwNumberOfProcessors; public uint dwProcessorType; public uint dwAllocationGranularity; public uint dwProcessorLevel; public uint dwProcessorRevision; } ... [DllImport("kernel32")] static extern void GetSystemInfo(ref SYSTEM_INFO pSI); ... SYSTEM_INFO pSI = new SYSTEM_INFO(

Azure AD and AWS Cognito side-by-side

In the last few weeks, I was involved in multiple opportunities on Microsoft Azure and Amazon, where we had to analyse AWS Cognito, Azure AD and other solutions that are available on the market. I decided to consolidate in one post all features and differences that I identified for both of them that we should need to take into account. Take into account that Azure AD is an identity and access management services well integrated with Microsoft stack. In comparison, AWS Cognito is just a user sign-up, sign-in and access control and nothing more. The focus is not on the main features, is more on small things that can make a difference when you want to decide where we want to store and manage our users.  This information might be useful in the future when we need to decide where we want to keep and manage our users.  Feature Azure AD (B2C, B2C) AWS Cognito Access token lifetime Default 1h – the value is configurable 1h – cannot be modified

ADO.NET provider with invariant name 'System.Data.SqlClient' could not be loaded

Today blog post will be started with the following error when running DB tests on the CI machine: threw exception: System.InvalidOperationException: The Entity Framework provider type 'System.Data.Entity.SqlServer.SqlProviderServices, EntityFramework.SqlServer' registered in the application config file for the ADO.NET provider with invariant name 'System.Data.SqlClient' could not be loaded. Make sure that the assembly-qualified name is used and that the assembly is available to the running application. See http://go.microsoft.com/fwlink/?LinkId=260882 for more information. at System.Data.Entity.Infrastructure.DependencyResolution.ProviderServicesFactory.GetInstance(String providerTypeName, String providerInvariantName) This error happened only on the Continuous Integration machine. On the devs machines, everything has fine. The classic problem – on my machine it’s working. The CI has the following configuration: TeamCity .NET 4.51 EF 6.0.2 VS2013 It see